Skip to content

Support for deploying Network Information plugins#215

Open
zakalawe wants to merge 2 commits into
linuxdeploy:masterfrom
zakalawe:deploy-network-information-plugins
Open

Support for deploying Network Information plugins#215
zakalawe wants to merge 2 commits into
linuxdeploy:masterfrom
zakalawe:deploy-network-information-plugins

Conversation

@zakalawe
Copy link
Copy Markdown

@zakalawe zakalawe commented Apr 6, 2026

Fixes: #154

Copy link
Copy Markdown
Contributor

@dantti dantti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheAssassin
Copy link
Copy Markdown
Member

Have not tested this explicitly, but it looks good. If CI agrees, let's merge this. Thanks @zakalawe!

@TheAssassin
Copy link
Copy Markdown
Member

Not sure why, but the actions workflow has not run. Maybe @zakalawe has disabled that in their fork?

@zakalawe
Copy link
Copy Markdown
Author

Not sure why, but the actions workflow has not run. Maybe @zakalawe has disabled that in their fork?

I didn't actively enable or disable it, when creating the fork, so not sure what is going on.

@zakalawe
Copy link
Copy Markdown
Author

Not sure why, but the actions workflow has not run. Maybe @zakalawe has disabled that in their fork?

I didn't actively enable or disable it, when creating the fork, so not sure what is going on.

And actions are enabled on my fork, indeed.

@TheAssassin
Copy link
Copy Markdown
Member

Looks like after a few refreshes, the approval button showed up. GitHub doing GitHub things.

@TheAssassin
Copy link
Copy Markdown
Member

Ah, I see that you pushed an update commit. That's probably why it worked this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The networkinformation plugins are not deployed

3 participants